Fix MSVC "possible loss of data" warning#434
Merged
azeey merged 1 commit intogazebosim:gz-msgs10from Mar 19, 2024
Merged
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-msgs10 #434 +/- ##
==========================================
Coverage 98.19% 98.19%
==========================================
Files 27 27
Lines 1166 1166
==========================================
Hits 1145 1145
Misses 21 21 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
Mar 19, 2024
azeey
pushed a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The warning appears in
gz-launchand it's due to the fact that we're assigning auint64_tto anint32_t.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.